[Cleanup] Remove deprecated APIs #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That includes following properties that are declared on ASDisplayNode and ASLayoutSpec: spacingBefore, spacingAfter, flexGrow, flexShrink, flexBasis, alignSelf, ascender, descender, sizeRange and layoutPosition.
-visibilityDidChange: -visibleStateDidChange: -displayStateDidChange: -loadStateDidChange:
…thod in ASPagerDelegate
|
🚫 CI failed with log |
maicki
approved these changes
Aug 23, 2017
There was a problem hiding this comment.
Awesome, agree with @nguyenhuy, feels good to see that code going away. We should do a bigger release, 2.5 sounds fine for me.
@nguyenhuy We should also run it against P to see if we run into any issues we can prevent before merging / releasing a new version.
|
@maicki Yes, I have a pending branch that fixes issues in P. Gonna leave this PR for another day or two before merging, in case someone else wants to chime in. |
Generated by 🚫 Danger |
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
* Remove preferredFrameSize * Remove -measure: * Remove -measureWithSizeRange: * Remove ASLayoutable * Remove .name * Remove deprecated style forwardings That includes following properties that are declared on ASDisplayNode and ASLayoutSpec: spacingBefore, spacingAfter, flexGrow, flexShrink, flexBasis, alignSelf, ascender, descender, sizeRange and layoutPosition. * Remove usesImplicitHierarchyManagement * Remove deprecated range update callbacks: -visibilityDidChange: -visibleStateDidChange: -displayStateDidChange: -loadStateDidChange: * Remove -clearFetchedData * Remove -cancelLayoutTransitionsInProgress * Remve ASDisplayNode+Deprecated.h * Remove ASLayoutRangeTypeRender and ASLayoutRangeTypeFetchData * Remove -[ASTableView clearContents] * Remove reloadDataImmediately * Remove ASStaticLayoutSpec * Remove ASDimensionDeprecated * Remove optional -pagerNode:constrainedSizeForNodeAtIndex: delegate method in ASPagerDelegate * Remove suppressesInvalidCollectionUpdateExceptions * Remove -[ASCollectionViewLayoutInspector initWithCollectionView] * Remove ASVideoPlayerNode.loadAssetWhenNodeBecomesVisible * Update CHANGELOG * Update license of ASLayoutSpecTests.m * Update examples/PagerNode * Remove ASEnvironmentTraitCollection * Remove -ASViewController.nodeConstrainedSize * More on removing ASLayoutable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove APIs that have been deprecated since 2.0 and/or for at least 6 months:
-ASDisplayNode.preferredFrameSize.-[ASDisplayNode measure:]and-[ASDisplayNode measureWithSizeRange:].ASLayoutable.-ASDisplayNode.name.spacingBefore,spacingAfter,flexGrow,flexShrink,flexBasis,alignSelf,ascender,descender,sizeRangeandlayoutPositionofASDisplayNodeandASLayoutSpec.+ASDisplayNode.usesImplicitHierarchyManagement.ASDisplayNode:-visibilityDidChange:,-visibleStateDidChange:,-displayStateDidChange:,-loadStateDidChange:.-clearFetchedDataofASDisplayNodeandASTableView.-[ASDisplayNode cancelLayoutTransitionsInProgress].ASLayoutRangeTypeRenderandASLayoutRangeTypeFetchData.-[ASTableView clearContents].-reloadDataImmediatelyof table and collection views and nodes.ASStaticLayoutSpecandASDimensionDeprecated.-pagerNode:constrainedSizeForNodeAtIndex:delegate method ofASPagerDelegate.+ASDisplayNode.suppressesInvalidCollectionUpdateExceptions.-[ASCollectionViewLayoutInspector initWithCollectionView:].-ASVideoPlayerNode.loadAssetWhenNodeBecomesVisible.ASEnvironmentTraitCollection.The next release should be a major release (2.5). Sorry for the huge PR, but I couldn't stop digging down the rabbit hole. It feels so good!