[Gallery layout] Include the caller in properties providing methods #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nguyenhuy
commented
Aug 25, 2017
nguyenhuy
commented
- This is the convention for delegate methods.
- Clients can use the caller to decide which value to return, for example when they have multiple layouts using the same provider.
nguyenhuy
force-pushed
the
HNPropertiesProviderWithCallee
branch
from
ada6985
to
bce2754
Compare
nguyenhuy
changed the title
maicki
approved these changes
Aug 25, 2017
| @@ -148,7 +148,7 @@ - (NSInteger)indexOfPageWithNode:(ASCellNode *)node | |||
|
|
|||
| #pragma mark - ASCollectionGalleryLayoutPropertiesProviding | |||
|
|
|||
| - (CGSize)sizeForElements:(ASElementMap *)elements | |||
| - (CGSize)galleryLayoutDelegate:(nonnull ASCollectionGalleryLayoutDelegate *)delegate sizeForElements:(nonnull ASElementMap *)elements | |||
There was a problem hiding this comment.
Will this be a breaking API change or do we see the ASCollectionGalleryLayout as beta or not announced yet?
There was a problem hiding this comment.
Yes, the whole async collection layout API is still in beta.
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…extureGroup#533) * Include the caller in ASCollectionGalleryLayoutPropertiesProviding's methods * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.