[RTL] Bridge the UISemanticContentAttribute property for more convenient RTL support. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appleguy
force-pushed
the
SemanticContent
branch
from
de4f1f0 to
abe2d66
Compare
appleguy
added a commit
that referenced
this pull request
Apr 23, 2017
…ent RTL support. Although apps could handle this before by setting the view's property in didLoad, it's useful to bridge this property for setting during off-main initialization. This change also makes RTL fully functional / automatic for Yoga layout users.
appleguy
force-pushed
the
SemanticContent
branch
from
abe2d66 to
dcda180
Compare
appleguy
commented
Apr 23, 2017
| @property (nonatomic, assign) CGRect bounds; | ||
| @property (nonatomic, assign) CGRect frame; // Only for use with nodes wrapping synchronous views | ||
| @property (nonatomic, assign) UIViewContentMode contentMode; | ||
| @property (nonatomic, assign) BOOL clipsToBounds; |
There was a problem hiding this comment.
These were re-indented, because they had actually included tab characters as well as spaces (making it impossible to line up on GitHub even though it did in Xcode)
Generated by 🚫 Danger |
maicki
approved these changes
Apr 24, 2017
|
Thanks for the super-quick review, @maicki :) |
maicki
pushed a commit
that referenced
this pull request
Apr 27, 2017
…#59) * [Yoga Beta] Improvements to the experimental support for Yoga layout. Yoga remains an unsupported / speculative feature, but these improvements are important for the functionality of clients that are experimenting with it. For example, without these changes, ASButtonNode is not able to lay out correctly. These changes allow certain subtrees that use layout specs to coexist properly in a Yoga heirarchy. The most significant change here is moving ASEdgeInsets into the #if YOGA gating. Although this is technically an API change, this type was added with no known use cases and is really only useful for flexbox layout specification. So, before usages of it are created, it makes sense to constrain the Texture API surface until that time. * [RTL] Bridge the UISemanticContentAttribute property for more convenient RTL support. Although apps could handle this before by setting the view's property in didLoad, it's useful to bridge this property for setting during off-main initialization. This change also makes RTL fully functional / automatic for Yoga layout users. * Remove RTL property addition and depend on PR #60 landing first. * Fix warnings * Add line to changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although apps could handle this before by setting the view's property in didLoad, it's
useful to bridge this property for setting during off-main initialization.
This change is required in order to finalize and land https://github.com/TextureGroup/Texture/pull/59/files - or otherwise I can do a followup PR to merge the small amount of code in +UIViewBridge that gives an opportunity to update other state when this attribute changes.