Revert Adds support for specifying a quality indexed array of URLs #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maicki
approved these changes
Dec 5, 2017
|
Please add a quick explanation. |
|
@nguyenhuy Done :) |
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…extureGroup#699) * Revert "Adds support for specifying a quality indexed array of URLs (TextureGroup#557)" This reverts commit 3c77d4a. * Add CHANGELOG entry
|
when the url is not image url，my app must crash. 'downloadIdentifier = [self->_downloader downloadImageWithURL:url' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#557
This reverts commit 3c77d4a.
This removes support for specifying multiple URLs on an ASNetworkImageNode. We decided to remove this for now because of the added complexity and the confusion between this and ASMultiplexImageNode.
This functionality may return at some point in another form.