Enable collection node interactive moves #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maicki
approved these changes
Jan 5, 2018
Source/ASCollectionView.mm
Outdated
| // In iOS >= 11, this is made much easier by the UIDataSourceTranslating API. In previous versions of iOS our best bet | ||
| // would be to capture the invalidation contexts that are sent during interactive moves and make our own data source translator. | ||
| if ([self.collectionViewLayout isKindOfClass:[ASCollectionLayout class]]) { | ||
| return NO; |
There was a problem hiding this comment.
Should we print out some log here to let user know about it?
|
#141. |
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
* Add support for interactive moves * Enable drag & drop in collection view example * Update changelog * Change the gating logic to match UIKit * Add a warning when we prevent interactive movement due to async layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch enables interactive movement for collection node items and updates the
ASCollectionViewexample to showcase it.Caveats:
- (BOOL)collectionView:(UICollectionView *)collectionView canMoveItemAtIndexPath:(NSIndexPath *)indexPathfor details.To use:
collectionNode:moveItemAtIndexPath:toIndexPath:.collectionNode:canMoveItemWithNode:. As with UIKit, this defaults toYESas long as you implement the move method.UICollectionViewinteractive movement methods, such asbeginInteractiveMovementForItemAtIndexPath:. We will need to bridge or intercept these at this time.