Update dangerfile for 2018 #trivial #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Adlai-Holler
commented
Jan 15, 2018
| @@ -230,6 +230,8 @@ - (void)dealloc | |||
| { | |||
| CGColorRelease(_shadowColor); | |||
|
|
|||
| // TODO: This may not be necessary post-iOS-9 when most UIKit assign APIs | |||
| // were changed to weak. | |||
There was a problem hiding this comment.
This file was already modified post-Texture, so this change would have triggered a danger warning without the hack added in this diff.
Adlai-Holler
commented
Jan 15, 2018
| @@ -23,7 +23,7 @@ @implementation AppDelegate | |||
|
|
|||
| - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions | |||
| { | |||
| self.window = [[UIWindow alloc] initWithFrame:[[UIScreen mainScreen] bounds]]; | |||
| self.window = [[UIWindow alloc] initWithFrame:UIScreen.mainScreen.bounds]; | |||
There was a problem hiding this comment.
This file had not been modified post-Texture, so this file was checked against the new license text (hack did not apply.)
Adlai-Holler
force-pushed
the
AHDangerfile
branch
from
282aceb
to
13fccb0
Compare
Merged
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
* Update the dangerfile * Make a trivial change to test new dangerfile * Try out the new value with another trivial change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #745
I added a TODO inside of a "post-Texture-modified" file to test the new dangerfile.