Improve no-copy rendering experiment, remove +load method #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 28, 2018 15:25
appleguy
reviewed
Jan 28, 2018
| @@ -143,8 +143,9 @@ CGFloat ASScreenScale() | |||
| static CGFloat __scale = 0.0; | |||
| static dispatch_once_t onceToken; | |||
| dispatch_once(&onceToken, ^{ | |||
| ASDisplayNodeCAssertMainThread(); | |||
| __scale = [[UIScreen mainScreen] scale]; | |||
| UIGraphicsBeginImageContextWithOptions(CGSizeMake(1, 1), YES, 0); | |||
There was a problem hiding this comment.
@Adlai-Holler as an extra measure of safety, could you add a unit test that verifies the equality of [[UIScreen mainScreen] scale] with ASScreenScale()?
Adlai-Holler
added a commit
that referenced
this pull request
Jan 30, 2018
* Improve graphics contexts experiment * Update changelog * Remove extra space * Add a unit test for screen scale * Fix typo and use unique value
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…up#771) * Improve graphics contexts experiment * Update changelog * Remove extra space * Add a unit test for screen scale * Fix typo and use unique value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR achieves the following:
+loadmethod by changingASScreenScaleto useUIGraphicswhich is thread-safe.