Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #788 – Interface State Runloop Queue #861

Closed
wants to merge 1 commit into from

Conversation

Adlai-Holler
Copy link
Member

@Adlai-Holler Adlai-Holler commented Mar 28, 2018

Unfortunately, diff #788 has a few issues that need to be resolved before we can re-land it.

This reverts the diff until we can get these issues resolved.

maicki
maicki approved these changes Mar 28, 2018
@ghost
Copy link

ghost commented Mar 28, 2018

1 Warning
⚠️ This is a big PR, please consider splitting it up to ease code review.

Generated by 🚫 Danger

@appleguy
Copy link
Member

@Adlai-Holler thanks for putting this up — it sounds like there is a clear need to disable this by default.

To that end, I've asked my team to make this a P0 and we'll either submit a PR today that accomplishes this (with all the coalescing code bypassed by default, and original timing unchanged) — or alternatively we can land this revert if the path to disable has any complications.

I'll let you guys know within a few hours what we plan to do. Sorry to hear this has created some issues!

@Adlai-Holler
Copy link
Member Author

Adlai-Holler commented Mar 28, 2018

OK @appleguy that's super reasonable IMO. To disable the coalescing by default, modify the + (ASConfiguration *)defaultConfiguration method in ASConfigurationInternal.m and remove the Coalescing flag there.

@Adlai-Holler
Copy link
Member Author

Superseded by #862

@appleguy
Copy link
Member

Thanks for being on top of this - glad we could resolve quickly with a minimum of risk on the other PR.

@appleguy appleguy deleted the AHRevertInterfaceStateQueue branch March 29, 2018 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants