[Yoga] Increment Yoga version to current, 1.5.0. #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everything seems to build fine with this version, so I'll seek clarifying information from the reporter of this bug: #25
|
@appleguy Do you use 1.3 already? Should we just merge it for now? |
|
We are currently on 1.5.0 -- check out the podspec in my latest WIP PR.
Feel free to merge this, does it actually help that other issue? Also fine
to use 1.5.0.
…On Mon, May 15, 2017 at 9:50 AM Michael Schneider ***@***.***> wrote:
@appleguy <https://github.com/appleguy> Do you use 1.3 already? Should we
just merge it for now?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#91 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAigAwaAqqwsz-nMAOp-PJ1veEwpoqk1ks5r6IJAgaJpZM4NMe_8>
.
|
|
@appleguy Let's update this PR to 1.5 than and just merge it. Or what do you think? |
|
Sounds great!
…On Mon, May 15, 2017 at 10:00 AM Michael Schneider ***@***.***> wrote:
@appleguy <https://github.com/appleguy> Let's update this PR to 1.5 than
and just merge it. Or what do you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#91 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAigAyHuc8HsBJ8w7Kk4wEjVYyI9TT2Pks5r6ISYgaJpZM4NMe_8>
.
|
|
@appleguy Ok cool will do that now. |
maicki
changed the title
|
@appleguy I will merge this now as it seems the upgrade will work fine. |
|
This did not fix the issue I had. I have made this PR to show what was needed to make our particular project compile #306 |
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
* [Yoga] Increment Yoga version to current, 1.3.0 Everything seems to build fine with this version, so I'll seek clarifying information from the reporter of this bug: TextureGroup#25 * Update Yoga version to 1.5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything seems to build fine with this version, so I'll
seek clarifying information from the reporter of this bug:
#25