ASConfiguration version check only when have json dict

[wsdwsd0829]

copyWithZone:(NSZone *)zone will pass in nil which cause logging falsely.
Originated in ConfigurationManager: _config = [[ASConfiguration textureConfiguration] copy];

[maicki]

Let's wrap the whole getting the version out of dictionary in that != nil check:

if (dictionary != nil) {
  autotype version = ASDynamicCast(dictionary[@"version"], NSNumber).integerValue;
  if (version != ASConfigurationSchemaCurrentVersion) {
    // ...
  }
}

Ideally we could move parsing out the featureString also in that dictionary != nil check but it's not guaranteed that the experimentalFeatures property is initialized as 0 what ASExperimentalFeaturesFromArray will return if you pass in a nil featureString currently.

Looking into ASExperimentalFeaturesFromArray though, the input parameter is marked as nonnull. Ideally we should never pass in nil in the first place.

Either we adjust the nullable annotation / handling in ASExperimentalFeaturesFromArray or change the whole initializer to something like:

- (instancetype)initWithDictionary:(NSDictionary *)dictionary
{
  if (self = [super init]) {
    if (dictionary) {
      autotype featureStrings = ASDynamicCast(dictionary[@"experimental_features"], NSArray);
      autotype version = ASDynamicCast(dictionary[@"version"], NSNumber).integerValue;
      if (version != ASConfigurationSchemaCurrentVersion) {
        NSLog(@"Texture warning: configuration schema is old version (%zd vs %zd)", version, ASConfigurationSchemaCurrentVersion);
      }
      self.experimentalFeatures = ASExperimentalFeaturesFromArray(featureStrings);
      
    } else {
      self.experimentalFeatures = 0; // We may should add something like ASExperimentalNone
    }
  }
  return self;
}

[ghost]

	1 Warning
⚠️	Any source code changes should have an entry in CHANGELOG.md or have #trivial in their title.

Generated by 🚫 Danger

[Adlai-Holler]

Looks good to me!