Dev #24
Merged
Dev #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nicate properly with Lambda Infrastructure was also added to support more complicated logic within the function, such as resolving URLs.
Added logic for URL resolver which turns a url into a AWS BlogPost and throws IOException if fails
…s\GitHub\awsome-nlp with conflicts.
…egration' Conflicts: frontend/src/App.js src/App.js
Translated posts are shown on the right in JSON format.
…them up and translating them paragraph by paragraph.
…due to the flaky nature" This reverts commit 82109bf.
Blog posts are correctly displayed with Title, authors, and translated content
Removed pipeline error
Translated URL was hardcoded, but now the translated URL is the one from inputted react form
Authors were incorrectly processed in the backend. This commit accesses the Correct HTML element(s)
Revert 6 translate long post
Rhs integration
In this commit, the checkstyle was also fixed according to a modified Sunchecks style. An initial Unit Test was also added.
Backend Testing, Title Translation, and Checkstyle
* pipeline hotfix * removed cloud backend * re added proper cloud backend * changed directory of cloud backend * change the name of the api so amplify doesn't complain
* appsync connected and lambda created * appsync connected and lambda created Co-authored-by: Athanasios Christopoulos <athan29@users.noreply.github.com> * appsycn connected and lmabda created * appsync connected to graphql * almost done(cap) * bomba * html is returned now * trial * commit * title added to html * html is returned properly now * blabla * sdgsg * idk why i have changes * updated apppy * updated html * added response * updated other appjs * working on frontend * almost * dsf * updated schema * merge confloct? * smth * html fix * response added * pretty close * pushing p * fixed inner html * omg almost perfect * saf * added a chcek for aws urls * aws blog post valid url checked * cleanup * NOFUCKINGWAY * Pipeline * gitignore * merge conflict headers resolved * merge conflict header resolved * merge conflict header resolved * gitignore updated * gitignore complete --------- Co-authored-by: Lara Sakarya <L.Sakarya@student.tudelft.nl> Co-authored-by: Athanasios Christopoulos <athan29@users.noreply.github.com>
* Create python-app.yml * Modified Requirements.txt to reflect actual libraries used * Modified python pipeline to run on every push * Changed the working directory for python pipeline * Added an initial pytest
* Added all Documents Added all necessary Documents including report, code of conduct, and notes * Removed meme images unnecessary meme images were removed
Deleted unnecessary frontend and unignored changes
This will prevent having to change build config on account reset
* Added initial Test files and refactored AWSBlogPost to be more testable. Changed the checkstyle to remove checks for class design since it interferes with test classes. When testing, it was apparent that some classes are poorly designed. They need to be refactored. * FIxed the bug where some blog posts would repeat translated elements by making a new request object everytime (probably java being smart and optimizing some code away) * Used explicit mock instead of annotations to initialize mock * Added first integration test * Added Jacoco for Unit Testing Reports * Added Baisc Unit Tests for every class with logic, and an integration test. * Removed unecessary jacoco part in build.gradle * Refactored AWSBlogPosts and Text classes to make more sense * fixed checkstyle
* adding skeleton readme.md * Changes node versions for pipeline
* Added rating to graphql schema * Added the star elements to the front-end * Made the star element appear only after completion of translation * added jacoco proper report to UserConfigFunction * updated package-lock.json * Added generated graphql queries for new API that includes rating * Added logic to send and mutate the rating to the backend using the star rating * hotfix * hotfix ridiculous typo * Updated graphql queries to reflect the queries actually occuring * made functions async to deal with uncaught promise * Fixed visibility bug for ratingId variable that prevented the graphql call from going through.
|
pipeline passes 🚀 🚀 🚀 |
larasakarya
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.