Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert translation issue #43

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

revert translation issue #43

wants to merge 3 commits into from

Conversation

athan29
Copy link
Collaborator

@athan29 athan29 commented Jun 26, 2023

No description provided.

@athan29 athan29 requested a review from kyoncal June 26, 2023 14:10
@aws-amplify-eu-west-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-43.d30hvp8x3d2hs6.amplifyapp.com

@kyoncal
Copy link
Collaborator

kyoncal commented Jun 26, 2023

What is the point of this pull request?

kyoncal
kyoncal requested changes Jun 26, 2023
View reviewed changes
amplify/backend/function/UserConfigFunction/gradle/wrapper/gradle-wrapper.properties Outdated
distributionUrl=https\://services.gradle.org/distributions/gradle-7.3-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.4-bin.zip
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not mess with distro versions negative 19 hours before the deadline.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair, i can change that back.

@athan29
Copy link
Collaborator Author

athan29 commented Jun 26, 2023 •
edited
Loading

What is the point of this pull request?

reverting the thing that broke the translation

@kyoncal
Copy link
Collaborator

kyoncal commented Jun 26, 2023

What is the point of this pull request?

reverting the thing that broke the translation

This function has been like this for weeks (at least 2). This did not break the function.

@kyoncal
Copy link
Collaborator

kyoncal commented Jun 26, 2023

What is the point of this pull request?

reverting the thing that broke the translation

This function has been like this for weeks (at least 2). This did not break the function.

The last major change to this file was made June 7th. There were certainly working translations between now and then. This change did not change the functionality of the funciton, only the implementation. The fact that the blackbox tests remained the same before and after the commit on June 7th (hash: dee8732) shows this fact.

@athan29
Copy link
Collaborator Author

athan29 commented Jun 26, 2023

What is the point of this pull request?

reverting the thing that broke the translation

This function has been like this for weeks (at least 2). This did not break the function.

The last major change to this file was made June 7th. There were certainly working translations between now and then. This change did not change the functionality of the funciton, only the implementation. The fact that the blackbox tests remained the same before and after the commit on June 7th (hash: dee8732) shows this fact.

This commit was pushed onto dev 2 days ago: 51acb89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyoncal kyoncal kyoncal requested changes

@Tezzish Tezzish Awaiting requested review from Tezzish

@larasakarya larasakarya Awaiting requested review from larasakarya

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@athan29 @kyoncal @Tezzish