Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return error if MaxSessions=1 #61

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Return error if MaxSessions=1 #61

merged 1 commit into from
Oct 24, 2019

Conversation

dmjones
Copy link
Contributor

@dmjones dmjones commented Oct 24, 2019

Return an error rather than panicking if MaxSessions=1 in the config. Add doc comments indicating that MaxSessions cannot be 1.

Fixes #60

@dmjones dmjones added the has issue Used to exclude PRs from release notes label Oct 24, 2019
@dmjones dmjones merged commit c6ebc96 into master Oct 24, 2019
@dmjones dmjones deleted the fix-min-sessions branch October 24, 2019 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sburton84 sburton84 sburton84 approved these changes

@nickrmc83 nickrmc83 Awaiting requested review from nickrmc83

Assignees
No one assigned
Labels
has issue Used to exclude PRs from release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic when MaxSessions is 1
2 participants
@dmjones @sburton84