Fix as_date()'s std::bad_cast with decimal value #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 13, 2022 15:20
1 task
Prosperoh
changed the title
Prosperoh
changed the title
Thalhammer
reviewed
Sep 13, 2022
Thalhammer
approved these changes
Sep 14, 2022
Signed-off-by: Dominik Thalhammer <dominik@thalhammer.it>
Signed-off-by: Dominik Thalhammer <dominik@thalhammer.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the timestamp value for the date is a decimal number, round it to the closest integer. This allows date claims to have a decimal value, though it will be rounded up to the closest second.