-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented JsonCPP Traits #317
Conversation
Thank you so much for this great addition! This bit requires a bunch of CI to ensure consistency so I took the liberty of adding (most of it 🤞) there are a hand full of linter checks that are failing and I suspect there will be some compilation failures... especially in the test which I am not familiar with the API of this library. Any help fixing it up will be appreciated! I took some liberties with naming just to make it |
"they" do not maintain the CMake scripts so this will be fun open-source-parsers/jsoncpp#455 (comment)
API does not match exactly but seems very close https://github.com/Thalhammer/jwt-cpp/actions/runs/7153838549/job/19480726737?pr=317#step:11:1786 |
You're welcome! It's a really popular library so I know it'll be helpful to people. I can take a look at the API issues this week if you'd like. |
…ed from sets of values
I think a future task will be to more the "linters" from nodejs to CMake so thier are more friendly to run locally because it's kinda a pain |
My project already makes heavy use of json-cpp so I put together this implementation of json-cpp traits for the jwt-cpp library since it seems like others have been asking for it as well.