Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor base64 decoding to use a lookup table #364

Merged
merged 3 commits into from
Nov 17, 2024
Merged

Refactor base64 decoding to use a lookup table #364

merged 3 commits into from
Nov 17, 2024

Conversation

ItsAMeMarcel
Copy link
Contributor

Resolves #362 - Performance Bottleneck in jwt::decoded_jwt due to Linear Search

Thalhammer
Thalhammer approved these changes Nov 7, 2024
View reviewed changes
Copy link
Owner

@Thalhammer Thalhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

prince-chrismc
prince-chrismc approved these changes Nov 17, 2024
View reviewed changes
Copy link
Collaborator

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo for the next release but this should be a remark, it's not part of the documented API but still a breaking change incase someone did use this

@prince-chrismc prince-chrismc merged commit 59cdb43 into Thalhammer:master Nov 17, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@Thalhammer Thalhammer Thalhammer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance Bottleneck in jwt::decoded_jwt due to Linear Search
3 participants
@ItsAMeMarcel @Thalhammer @prince-chrismc