Doors and buttons #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omangbaheti
reviewed
Nov 3, 2022
| private void Awake() | ||
| { | ||
| doorControllers = new List<DoorController>(); | ||
| _button = transform.GetChild(1).gameObject; |
There was a problem hiding this comment.
why not a sf reference? this is fine though tbh
There was a problem hiding this comment.
since it was going to be used by others. I thought it would be easier that way.
|
|
||
| private void Start() | ||
| { | ||
| _counterTile = transform.GetChild(1).GetChild(0).gameObject; |
There was a problem hiding this comment.
kinda hacky, could be an sf especially if it requires two layers of getchild?
| _buttons = new List<ButtonBehaviour>(buttonDictionary.Keys); | ||
| _values = new List<int>(buttonDictionary.Values); | ||
|
|
||
| foreach (var button in _buttons) |
There was a problem hiding this comment.
dictionaries are directly iterable, you dont need to split it and convert it into a list
There was a problem hiding this comment.
i tried
i think serializable dictionaries work diferent
| if (tempOpen) return; | ||
| _buttonActivated = true; | ||
| for (int i = 0; i < _buttons.Count; i++) | ||
| if (_buttons[i] == button) |
There was a problem hiding this comment.
you can just do _index = buttonDictionary[button]; instead of the entire for() loop and eliminate the entire ConvertToDictionary() function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.