fix(front): remove url setter and getter

ThatOpen · Aug 29, 2024 · 8be541e · 8be541e
1 parent 5bed53b
commit 8be541e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 22 deletions.
diff --git a/packages/front/package.json b/packages/front/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@thatopen/components-front",
   "description": "Collection of frontend tools to author BIM apps.",
-  "version": "2.3.0-alpha.9",
+  "version": "2.3.0-alpha.10",
   "author": "That Open Company",
   "contributors": [
     "Antonio Gonzalez Viegas (https://github.com/agviegas)",

diff --git a/packages/front/src/fragments/IfcStreamer/index.ts b/packages/front/src/fragments/IfcStreamer/index.ts
@@ -80,7 +80,11 @@ export class IfcStreamer extends OBC.Component implements OBC.Disposable {
 
   private _fileDB = new StreamerFileDb();
 
-  private _url: string = "";
+  /**
+   * The URL of the data source for the streaming service.
+   * It should be set before using the streaming service. Alternatively, you can use a custom fetch function.
+   */
+  private url: string = "";
 
   private _isDisposing = false;
 
@@ -104,26 +108,6 @@ export class IfcStreamer extends OBC.Component implements OBC.Disposable {
     opacity: 0.5,
   });
 
-  /**
-   * The URL of the data source for the streaming service.
-   * It must be set before using the streaming service.
-   * If not set, an error will be thrown when trying to access the URL.
-   */
-  get url() {
-    if (!this._url) {
-      throw new Error("url must be set before using the streaming service!");
-    }
-    return this._url;
-  }
-
-  /**
-   * Sets the URL of the data source for the streaming service.
-   * @param value - The new URL to be set.
-   */
-  set url(value: string) {
-    this._url = value;
-  }
-
   /**
    * The world in which the fragments will be displayed.
    * It must be set before using the streaming service.