Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Sublime text port to port list #43

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Added Sublime text port to port list #43

merged 1 commit into from
Nov 18, 2022

Conversation

imnotril
Copy link
Contributor

Added my Sublime text port, love ur color scheme <33

@ThatXliner ThatXliner merged commit 65c4a4a into ThatXliner:master Nov 18, 2022
@ThatXliner
Copy link
Owner

Glad you’re liking it!

@ThatXliner
Copy link
Owner

@imnotril even though I’ve merged it for now, I would like a few suggestIons

  1. I don’t use Sublime Text anymore but I do remember there being a package manager. I wonder if you are able to submit the package to package control https://packagecontrol.io/docs/submitting_a_package
  2. The punctuation in your port is white (although I suppose that’s a limitation of the theming in Sublime Text)

@imnotril
Copy link
Contributor Author

imnotril commented Nov 19, 2022

@ThatXliner I have been making changes to the color scheme to publish it in the package manager and I wanted to know, @mono-2 is the punctuation color?

@imnotril
Copy link
Contributor Author

@ThatXliner The package is in the process of being published into package control.

Although it needs to be checked, you can see the pr.

@ThatXliner
Copy link
Owner

@mono-2 is the punctuation color?

yes it is

@imnotril
Copy link
Contributor Author

  1. I don’t use Sublime Text anymore but I do remember there being a package manager. I wonder if you are able to submit the package to package control https://packagecontrol.io/docs/submitting_a_package

Done, although it may take some time for the color scheme to be published in the package manager.

  1. The punctuation in your port is white (although I suppose that’s a limitation of the theming in Sublime Text)

Done, even though some symbols fail because they are considered meta.* and not punctuation.*. Although there are very few symbols I could try to fix it in the future, but I think I'll leave it like this for now because I have to learn more about sublime text scopes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants