feat:added roles permission check for webhooks and server script

The-Commit-Company · Apr 12, 2024 · 8b783ad · 8b783ad
1 parent 5f93eeb
commit 8b783ad
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 10 deletions.
diff --git a/raven-app/src/components/feature/settings/Integrations.tsx b/raven-app/src/components/feature/settings/Integrations.tsx
@@ -1,28 +1,31 @@
 import { SidebarGroup, SidebarGroupItem, SidebarGroupLabel, SidebarGroupList, SidebarItem } from "@/components/layout/Sidebar"
+import { hasServerScriptEnabled, isSystemManager } from "@/utils/roles"
 import { Flex, Text } from "@radix-ui/themes"
 import { BiPlug } from "react-icons/bi"
 
 export interface Props { }
 
 export const Integrations = (props: Props) => {
+
+    const canAddUsers = isSystemManager()
+
+    const serverScriptEnabled = hasServerScriptEnabled()
+
     return (
         <SidebarGroup>
             <SidebarGroupItem gap='2' className={'pl-1.5'}>
-                {/* <SidebarViewMoreButton onClick={toggle} /> */}
                 <BiPlug />
                 <Flex width='100%' justify='between' align='center' gap='2'>
-                    <Flex gap='3' align='center'>
+                    {canAddUsers && <Flex gap='3' align='center'>
                         <SidebarGroupLabel className='cal-sans'>Integrations</SidebarGroupLabel>
-                    </Flex>
+                    </Flex>}
                 </Flex>
             </SidebarGroupItem>
             <SidebarGroup>
-                <SidebarGroupList>
+                {canAddUsers && <SidebarGroupList>
                     <IntegrationsItem route='/settings/integrations/webhooks' label='Webhooks' />
-                    {/* <IntegrationsItem route='/settings/integrations/doctype-events' label='Document Events' /> */}
-                    <IntegrationsItem route='/settings/integrations/scheduled-messages' label='Scheduled Messages' />
-                    {/* <IntegrationsItem route='/settings/integrations/api-events' label='API Events' /> */}
-                </SidebarGroupList>
+                    {serverScriptEnabled && <IntegrationsItem route='/settings/integrations/scheduled-messages' label='Scheduled Messages' />}
+                </SidebarGroupList>}
             </SidebarGroup>
         </SidebarGroup>
     )

diff --git a/raven-app/src/components/layout/Sidebar/SidebarFooter.tsx b/raven-app/src/components/layout/Sidebar/SidebarFooter.tsx
@@ -53,8 +53,8 @@ export const SidebarFooter = ({ isSettingsPage = false }: { isSettingsPage?: boo
                                     Mobile App
                                 </Link>
                             </DropdownMenu.Item>
-                            {!isSettingsPage && canAddUsers && <DropdownMenu.Item color='gray' className='focus-visible:ring-0 focus-visible:outline-none rounded-radius2' asChild>
-                                <Link href="../settings/integrations/webhooks" className='no-underline'>
+                            {!isSettingsPage && <DropdownMenu.Item color='gray' className='focus-visible:ring-0 focus-visible:outline-none rounded-radius2' asChild>
+                                <Link href="../settings" className='no-underline'>
                                     Settings
                                 </Link>
                             </DropdownMenu.Item>}

diff --git a/raven-app/src/utils/roles.ts b/raven-app/src/utils/roles.ts
@@ -10,4 +10,12 @@ export const hasRavenUserRole = () => {
 export const isSystemManager = () => {
     //@ts-expect-error
     return (window?.frappe?.boot?.user?.roles ?? []).includes('System Manager');
+}
+
+export const hasServerScriptEnabled = () => {
+    if (import.meta.env.DEV) {
+        return true
+    }
+    // @ts-expect-error
+    return (window?.frappe?.boot?.server_script_enabled)
 }
diff --git a/raven/www/raven.py b/raven/www/raven.py
@@ -26,6 +26,14 @@ def get_context(context):
 			raise frappe.SessionBootFailed from e
 
 	boot["push_relay_server_url"] = frappe.conf.get("push_relay_server_url")
+
+	# add server_script_enabled in boot
+	if "server_script_enabled" in frappe.conf:
+		enabled = frappe.conf.server_script_enabled
+	else:
+		enabled = True
+	boot["server_script_enabled"] = enabled
+
 	boot_json = frappe.as_json(boot, indent=None, separators=(",", ":"))
 	boot_json = SCRIPT_TAG_PATTERN.sub("", boot_json)