Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added reaction-analytics button #1011

Conversation

pranavmene2000
Copy link
Contributor

@github-actions github-actions bot added the UI label Aug 11, 2024
@janhvipatil
Copy link
Member

janhvipatil commented Aug 12, 2024

@pranavmene2000 thank you for your PR, just a few suggestions here -

The count over here should be 5 right?
(https://github.com/user-attachments/assets/7c4c0d6b-af89-4ac8-bad2-e67f0c7b7f3a)

Also, rather than having count as a separate column, can we combine the emoji and count in one column like so -
Screenshot 2024-08-12 at 8 51 37 PM

Move the show all reactions button right next to the reactions rather than at the flex end and make it grey, as it is not a primary action.

@pranavmene2000
Copy link
Contributor Author

pranavmene2000 commented Aug 12, 2024

@janhvipatil Yes. This is just an example. I edited dom to add users, so that I can take a screenshot for an example.
But anyway, it will give the correct count as per the number of users.

@janhvipatil
Copy link
Member

Oh okay, also do we have a scroll inside if the users are over 1000?

@pranavmene2000
Copy link
Contributor Author

pranavmene2000 commented Aug 12, 2024

Oh okay, also do we have a scroll inside if the users are over 1000?

@janhvipatil
Inner Scroller:
reaction-scroller

@pranavmene2000 pranavmene2000 deleted the 939-show-all-reactions-on-a-message-grouped-by-emoji branch August 17, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants