Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show system messages when channel members are changed #1087

Conversation

nikkothari22
Copy link
Member

CleanShot 2024-10-11 at 19 43 26@2x

@nikkothari22 nikkothari22 merged commit b873f3f into develop Oct 11, 2024
2 of 3 checks passed
@nikkothari22 nikkothari22 deleted the 937-system-messages-for-addition-removal-of-users-from-a-channel-when-a-admin-is-changed-when-a-user-joins-leaves-the-channel branch October 11, 2024 14:14
@zaheer-srushty
Copy link

I just wanted to understand the workflow for this use case

Say, an employee A creates a Private Raven channel and adds employee B & C to the channel. Now, when the employee A leaves the organization, we mark the employee as Left in the HRMS & the user_id is disabled. In this case, the Raven Channel Member doctype for that user is still active and hence the switchover of Admin role to employee B never happens.

Can you explain how is this envisioned in Raven for switchover to occur automatically?

@nikkothari22
Copy link
Member Author

@zaheer-srushty Maybe we need to trigger the admin change if a user is disabled (there's a disabled flag in Raven User doctype). Currently, we don't do that, but it makes sense. Will create an issue for this. Should the disabled member be removed from all channels?

@zaheer-srushty
Copy link

Yes. The disabled member should be removed from all channels & threads... Also, I noticed that we are still able to send messages to a disabled user in a DM...I think the DM channel input should also be disabled...

@zaheer-srushty
Copy link

@nikkothari22 I think the system messages should be centered similar to the Date separator rather than having it aligned with the channel messages.

@nikkothari22
Copy link
Member Author

That was the initial thought. We tried that, it didn't look good, especially when you have a lot of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants