Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show embedded timestamps in messages #1097

Merged
merged 2 commits into from
Oct 13, 2024
Merged

Conversation

nikkothari22
Copy link
Member

@nikkothari22 nikkothari22 commented Oct 13, 2024

This PR detects "time" in any human readable format when a message is sent and embeds a timestamp in the message. When receivers see the message, they can hover over the timestamp to view it in their timezone.

image

Also works with arbritary time

image

@nikkothari22 nikkothari22 merged commit 0d2ef23 into develop Oct 13, 2024
2 of 3 checks passed
@nikkothari22 nikkothari22 deleted the allow-time-embeddings branch October 13, 2024 17:42
@nikkothari22
Copy link
Member Author

This looks wonky in scenarios like these:

image

Have to figure this out 🫠

@nikkothari22
Copy link
Member Author

Possible solution:

  1. Give the user an option to choose the mode they want to use: they can disable auto parsing, enable auto parsing but with strict mode, or with casual mode
  2. Give a button that the user can use to highlight text and then embed time in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants