fix: permissions error for LDAP login #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RJPvT Would there be a better way to handle this instead of ignoring permissions altogether. Maybe we skip creating a Raven User when the user is logging in using LDAP? |
|
@nikkothari22 there is no disctinction in ERPNEXT. LDAP login just saves the login date before the set_user. i've tried to have that resolved al lot of times but since it's breaking nobody wants to approve the PR. ignore_permissions in this case is not a problem since this subroutine can only be called from a logged in user and always calls the needed document (get_doc) or insert. |
nikkothari22
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently with an LDAP login the frappe User stays Guest until DESK is loaded. Guest however does not have permission to create Raven User so an Error is given (and login is not possible)