Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow users to login with Email link #693

Merged
merged 25 commits into from
Mar 1, 2024
Merged

feat: Allow users to login with Email link #693

merged 25 commits into from
Mar 1, 2024

Conversation

prathameshkurunkar7
Copy link
Member

@prathameshkurunkar7 prathameshkurunkar7 commented Feb 22, 2024 •
edited
Loading

This is a subtask of issue #640

Solution:

  1. Created necessary UI in Login Page.
  2. Performed HTTP POST call to send login link which is built in controller in frappe.
  3. Performed email validation check, and added callouts for success and error cases.

@prathameshkurunkar7 prathameshkurunkar7 self-assigned this Feb 22, 2024
@prathameshkurunkar7 prathameshkurunkar7 linked an issue Feb 22, 2024 that may be closed by this pull request
Allow users to login with Email link (easy) #692
Closed
@nikkothari22
Copy link
Member

@prathameshkurunkar7 Can we split the page into separate files so that it's easy to debug.
And we'll also need to add this to the mobile app.

nikkothari22 and others added 18 commits February 27, 2024 19:15
@nikkothari22 @prathameshkurunkar7
fix(mobile): refresh messages when user reacts
64e1b0b
@nikkothari22 @prathameshkurunkar7
fix: API path for creating a DM channel via search
cd23da2
@nikkothari22 @prathameshkurunkar7
fix: only show enabled users on mentions and add members
f2cfab3
@nikkothari22 @prathameshkurunkar7
fix: show error message if users have a role profile attached to them
e43ae72
@nikkothari22 @prathameshkurunkar7
fix: autofocus tiptap editor
11ff086
@nikkothari22 @prathameshkurunkar7
fix: permission checks + read channel type from cache
f9b3506
@nikkothari22 @prathameshkurunkar7
fix(ui): width of user avatar in message preview of mobile
1461cd3
@nikkothari22 @prathameshkurunkar7
fix(ui): wrap reactions on mobile app
5531a8d
@nikkothari22 @prathameshkurunkar7
fix: create raven user for website users if role is assigned to them
37ee58f
@nikkothari22 @prathameshkurunkar7
fix: scroll to current selected item in mention list
3d353c7
@nikkothari22 @prathameshkurunkar7
fix: do not fetch unread count for archived channels
d04abde
@nikkothari22 @prathameshkurunkar7
fix: mention list on mobile
25e1569
@nikkothari22 @prathameshkurunkar7
chore: bumped version to v1.4.1
2dd688d
@TITANiumRox @prathameshkurunkar7
feat: Raven Mentions child table
9445c41
@TITANiumRox @prathameshkurunkar7
feat: mentions
dea7b67
@sumitjain236 @prathameshkurunkar7
fix: moved vite to dependencies
a6c13d9
@sumitjain236 @prathameshkurunkar7
chore: bumped version to 1.4.2
664e712
@sumitjain236 @prathameshkurunkar7
fix: added install_depedencies
afd1526
@nikkothari22 nikkothari22 merged commit 4e3a9c3 into develop Mar 1, 2024
3 checks passed
@nikkothari22 nikkothari22 mentioned this pull request Apr 10, 2024
Merged
@nikkothari22 nikkothari22 deleted the 692-allow-users-to-login-with-email-link-easy branch November 12, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikkothari22 nikkothari22 Awaiting requested review from nikkothari22

Assignees

@prathameshkurunkar7 prathameshkurunkar7

Labels
💻 webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow users to login with Email link (easy)
4 participants
@prathameshkurunkar7 @nikkothari22 @TITANiumRox @sumitjain236