Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: generate description message for file upload #750

Merged
merged 1 commit into from
Apr 23, 2024
Merged

fix: generate description message for file upload #750

merged 1 commit into from
Apr 23, 2024

Conversation

prathameshkurunkar7
Copy link
Member

Solution:

  • Checked whether the channel is DM, or self or general channel and generated message accordingly.
  • Note: Check if the description for self-message seems appropriate?

@prathameshkurunkar7 prathameshkurunkar7 self-assigned this Mar 7, 2024
@nikkothari22 nikkothari22 merged commit 1294c62 into develop Apr 23, 2024
3 checks passed
@nikkothari22 nikkothari22 deleted the 710-need-to-change-the-description-message-while-adding-an-attachments-in-the-direct-message branch April 23, 2024 20:01
@prathameshkurunkar7 prathameshkurunkar7 mentioned this pull request Apr 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikkothari22 nikkothari22 nikkothari22 approved these changes

Assignees

@prathameshkurunkar7 prathameshkurunkar7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prathameshkurunkar7 @nikkothari22