Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore permissions when sending messages via bots #801

Merged
merged 1 commit into from
Apr 2, 2024
Merged

fix: ignore permissions when sending messages via bots #801

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion raven/raven_bot/doctype/raven_bot/raven_bot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,9 @@ def send_message(
"link_document": link_document,
}
)
doc.insert()
# Bots can probably send messages without permissions? Upto the end user to create bots.
# Besides sending messages is not a security concern, unauthorized reading of messages is.
doc.insert(ignore_permissions=True)
return doc.name

def create_direct_message_channel(self, user_id: str) -> str:
Expand Down
Loading