feat: emoji suggestions #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for emoji suggestions via the
:key. This is available on both web and mobile.By default, on typing ":", we show frequently used emojis. The emojis are fetched from the same database (emoji-picker-element), so anytime a new emoji is selected (either from suggestions, or from the emoji picker (button/reactions)), we increment the count of it's usage. This data is maintained in IndexedDB by emoji-picker-element - hence not shared across browsers.
Also fixed a bug (regression of #869) where the code and code block plugins were initialised multiple times.
This PR also fixes a FIXME added earlier related to the keyboard handler extension conflicting with the mention extensions. Simply reordering the extensions in the editor initialisation fixed the issue.