build: use workspaces #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-user-permission-error-on-raven-user fix: user permission error when updating profile on Raven
|
@blaggacao The base branch is "develop". Not main. We'll merge develop into main when we make a new release (which should be today) |
|
Ah it looks like you created the branch from main. |
|
Nice! Thanks a lot, your reaction time is refreshing and much appreciated. Thank you! 🤝 |
|
Looks like builds are failing on Frappe Cloud :( 
Might be related to this? |
|
Fixed the build issue via: 25a1b8c . Missed the extra workspace here. |
|
Ah! I'm sorry for the oversight. It had a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like other Frappe apps.
This, at the very least, avoids build issues (to be documented below):
This blocks: blaggacao/frappix#10