Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

springboot 3.1.8 적용 및 asciidoctor 설정 변경 #198

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Conversation

kevstevie
Copy link
Collaborator

@kevstevie kevstevie commented Feb 8, 2024

issue: #192

as-is

  • 3.0.13 GA버전 사용
  • api 명세 페이지 접속시 404 발생

to-be

  • 3.1.x 버전대 GA 버전인 3.1.8 적용
  • asciidoctor 버전 업그레이드 및 gradle 설정 변경

Copy link

sonarqubecloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@@ -18,8 +18,8 @@ dependencies {
testImplementation 'org.springframework.boot:spring-boot-starter-test'

// rest-assured
testImplementation 'io.rest-assured:rest-assured:5.3.0'
testImplementation 'io.rest-assured:spring-mock-mvc:5.3.0'
testImplementation 'io.rest-assured:rest-assured:5.3.2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.3.0 에서 특정 이슈가 있었던 건가요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이부분은 springboot 버전에 따른 버전 변경입니다.
jdk 17로 올리는 부분에서 기존에 org.asciidoctor.convert 2.4.0을 사용했는데 gradle 7.0이상에선 org.asciidortor.jvm.convert 3.3.2를 사용한다고 하네요

Copy link
Collaborator

@Cyma-s Cyma-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다. 수고 많으셨어요 👍🏻

@kevstevie kevstevie merged commit c485aeb into main Feb 9, 2024
2 checks passed
kevstevie added a commit that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants