Issue188 헤더 개선 #202
Merged
Issue188 헤더 개선 #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nan-noo
reviewed
Jul 2, 2024
Comment on lines
71
to
72
| width: 20px; | ||
| height: 20px; |
There was a problem hiding this comment.
감사합니다! rem 단위로 변경했습니다 😊
Comment on lines
+37
to
+38
| const isMainPage = location.pathname === PATHNAME.HOME; | ||
| const isCategoryDetailPage = location.pathname.startsWith( |
There was a problem hiding this comment.
지금은 두개니까 괜찮지만 뭔가 이런 페이지들이 많아지면 배열이나 객체로 관리하면 좋을 거 같네요!
- 뒤로가기 보여주는 페이지들[]
- 검색바 보여주는 페이지들[]
| @@ -33,7 +31,7 @@ function BookmarkListPage() { | |||
| return ( | |||
| <S.Container> | |||
| <S.HeaderWrapper> | |||
| <LeftIcon onClick={() => navigate(-1)} /> | |||
| <div></div> | |||
There was a problem hiding this comment.
현재 나의 맛집 페이지의 헤더가 뒤로 가기 버튼 - 나의 맛집 - 지도 순으로 되어 있는데, 전체 페이지 헤더에 뒤로 가기 버튼 을 추가하면서 나의 맛집 페이지의 헤더 중 뒤로 가기 버튼 을 삭제해야 했고, 따라서 빈 div 태그를 추가하여 레이아웃을 맞춰 주게 되었습니다!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #188
상세 화면
로고 대신 뒤로 가기 버튼 추가
불필요한 검색창 제거