Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue54 라우터 적용 #55

Merged
merged 7 commits into from
Jun 14, 2022

Conversation

uk960214
Copy link
Member

Closes #54

as-is

실제 앱 미구현, 라우터 미구현

to-be

라우터 구현 및 실제 페이지 옮기기

  • 전체 너비 통일 적용
  • 임시로 페이지 이동 링크 기본 추가
  • 컴포넌트에 있는 오타 일부 수정, 깨지는 헤더 스타일 일부 수정

@uk960214 uk960214 linked an issue Jun 13, 2022 that may be closed by this pull request
Comment on lines +13 to +22
function PageLayout() {
return (
<div id="app">
<Header />
<MainContainer>
<Outlet />
</MainContainer>
</div>
);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

근데 요거랑 메인에 children 쓰는거랑 어떤 차이야??

<헤더/>
<Main>
{children}  // <Routes> <Route /> ... </Routes>
</Main>

@nan-noo nan-noo merged commit d6340fa into The-Fellowship-of-the-matzip:develop Jun 14, 2022
@uk960214 uk960214 deleted the issue54 branch June 14, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

라우터 적용
2 participants