syn: move dont_use processing to yosys #1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will have to wait for 0.39 to be release and for us to qualify it in ORFS (so far not a trivial process each time). |
gadfort
reviewed
Feb 20, 2024
|
Waiting on #1848 |
merged |
* Use new dont_use flag for dfflibmap * Remove dont_use preprocessing from markDontUse.py * Rename markDontUse.py to preprocessLib.py Signed-off-by: Austin Rovinski <rovinski@nyu.edu>
|
@maliberty @vvbandeira ready for review. I rebased on master. |
maliberty
approved these changes
Mar 17, 2024
| exec $::env(UTILS_DIR)/markDontUse.py -p $::env(DONT_USE_CELLS) -i $f -o "../../[file tail $f]-mod.lib" | ||
| exec $::env(UTILS_DIR)/preprocessLib.py -i $f -o "../../[file tail $f]-mod.lib" |
There was a problem hiding this comment.
@gadfort FYI for the regular SC flow
There was a problem hiding this comment.
@maliberty thanks. I already switched over to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dont_useflag fordfflibmapdont_usepreprocessing frommarkDontUse.pymarkDontUse.pytopreprocessLib.pyThis change requires a sync from upstream yosys. Support was added in YosysHQ/yosys#4219; it should be upstream next month in yosys 0.39. Alternatively, we could update yosys immediately.