Open rcx v2 - branch: OpenRCX-v2

[dimitrisfotakis]

Capacitance and Resistance accuracy and performance improvements
Via resistance modeling
New capacitance modeling patterns
Multi-corner extraction
New fast geometry Search Engine
Python scripts to understand and visualize errors
Regression Testing suite
Miscellaneous commands - max_res, no_via_merge_res
New Comprehensive Pattern Set
Modeling based on FasterCap and not dependent on Commercial extractors

Restructuring of main C++ functions for readability and maintenance
Wire Organization
Connectivity Extraction Debugging and Regression Test
Pattern Recognition and Modeling
Pattern Generation for 3rd party Solvers
Model file generation
Modeling Debugging Routines
Compliance with OpenROAD coding standards

Internal/External Documentation of major functions
src/rcx/doc
src/rcx/calibration/fasterCap

[maliberty]

There are new commands that need to be documented in the README

read_process
rules_gen
metal_rules_gen
run_solver
write_rcx_model
init_rcx_model
bench_wires_gen

and new options that need documenting on

bench_wires
write_rules

[Please pull as I've made some updates to fix other issues]

[dimitrisfotakis]

will document these

…

On Tue, Nov 19, 2024 at 10:28 PM Matt Liberty ***@***.***> wrote: There are new commands that need to be documented in the README read_process rules_gen metal_rules_gen run_solver write_rcx_model init_rcx_model bench_wires_gen and new options that need documenting on bench_wires write_rules [Please pull as I've made some updates to fix other issues] — Reply to this email directly, view it on GitHub <#6154 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADK2TDU6NMJEFR7LADGJUWT2BQTZDAVCNFSM6AAAAABRXDCBWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBXGYYDOMZVGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[maliberty]

I can waive DCO for this PR but in the future please use "git commit -s" to sign your commits and avoid problems in the future. I'll also waive clang-tidy for now. The documentation is the last piece to get this merged as I've fixed the rest of the checks.

[gadfort]

@maliberty can this read the old RCX extraction decks we have? If not, this will break a lot of PDKs.

[maliberty]

@gadfort yes, I've run it through the ORFS suite. There is a -version option so the default is no change.

[gadfort]

@maliberty thanks for confirming :-)

[dimitrisfotakis]

I cleaned all obsolete user commands and wrote min documentation in src/rcx/doc/userOptions.README I am in the process of resolving the conflicts after git pull

…

On Tue, Nov 19, 2024 at 10:28 PM Matt Liberty ***@***.***> wrote: There are new commands that need to be documented in the README read_process rules_gen metal_rules_gen run_solver write_rcx_model init_rcx_model bench_wires_gen and new options that need documenting on bench_wires write_rules [Please pull as I've made some updates to fix other issues] — Reply to this email directly, view it on GitHub <#6154 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADK2TDU6NMJEFR7LADGJUWT2BQTZDAVCNFSM6AAAAABRXDCBWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBXGYYDOMZVGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[maliberty]

@dimitrisfotakis this no longer compiles for me:

/home/mliberty_openroad_tools/w3/tools/OpenROAD/src/rcx/src/process_ext.cpp:58:9: error: ?class rcx::extMain? has no member named ?setCurrentModel?; did you mean ?rcx::extRCModel* rcx::extMain::_currentModel?? (not accessible from this context)

[dimitrisfotakis]

I just pushed some fixes. it should build correctly now dimitri

…

On Thu, Nov 21, 2024 at 2:41 PM Matt Liberty ***@***.***> wrote: @dimitrisfotakis <https://github.com/dimitrisfotakis> this no longer compiles for me: /home/mliberty_openroad_tools/w3/tools/OpenROAD/src/rcx/src/process_ext.cpp:58:9: error: ?class rcx::extMain? has no member named ?setCurrentModel?; did you mean ?rcx::extRCModel* rcx::extMain::_currentModel?? (not accessible from this context) — Reply to this email directly, view it on GitHub <#6154 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADK2TDU4BH7TV6YEJVG476T2BZORLAVCNFSM6AAAAABRXDCBWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJSGUYDCMZQG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[maliberty]

Still missing docs for

write_rcx_model
init_rcx_model
read_rcx_tables
gen_solver_patterns
define_rcx_corners
get_model_corners
gen_rcx_model
bench_wires_gen

[dimitrisfotakis]

not in the userOptions.README ? do you need more?

…

On Thu, Nov 21, 2024 at 9:49 PM Matt Liberty ***@***.***> wrote: Still missing docs for write_rcx_model init_rcx_model read_rcx_tables gen_solver_patterns define_rcx_corners get_model_corners gen_rcx_model bench_wires_gen — Reply to this email directly, view it on GitHub <#6154 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADK2TDUM6B3ZGDA7FDBK7JT2B3AWHAVCNFSM6AAAAABRXDCBWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJSHEZDEMZTGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>