Hier-RTLMP Fix #6371
Open
Hier-RTLMP Fix #6371
+525
−364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…which converts the placement blockages into macros with fence constraints Signed-off-by: ZhiangWang033 <zhw033@ucsd.edu>
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
reviewed
Dec 17, 2024
There was a problem hiding this comment.
This file appears to have be reformatted unnecessarily.
maliberty
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Likewise, unnecessary reformatting.
maliberty
reviewed
Dec 17, 2024
| return false; | ||
| }; | ||
|
|
||
| if (checkBalance() == false) { |
There was a problem hiding this comment.
This appears to just be a workaround to the underlying TP bug. I think @AcKoucher has identified the root cause as being bad initial partitioning.
|
@AcKoucher should this be closed as you are folding it into another PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the TP invalid partitioning issue and add the real_blockage_flag which converts the placement blockages into macros with fence constraints. Also, the IO blockage will be treated as placement blockages.