Hier connect with test #6413
Open
Hier connect with test #6413
+1,093
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andyfox-rushc <andy@rushc.com>
Signed-off-by: andyfox-rushc <andy@rushc.com>
Signed-off-by: andyfox-rushc <andy@rushc.com>
Signed-off-by: andyfox-rushc <andy@rushc.com>
Signed-off-by: andyfox-rushc <andy@rushc.com>
…mode Signed-off-by: andyfox-rushc <andy@rushc.com>
Signed-off-by: andyfox-rushc <andy@rushc.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/dbSta/test/cpp/TestHconn.cpp
Outdated
Comment on lines
128
to
130
| for (dbSet<dbModBTerm>::iterator mod_bterm_iter = module_ports.begin(); | ||
| mod_bterm_iter != module_ports.end(); | ||
| mod_bterm_iter++) { |
There was a problem hiding this comment.
warning: use range-based for loop instead [modernize-loop-convert]
Suggested change
| for (dbSet<dbModBTerm>::iterator mod_bterm_iter = module_ports.begin(); | |
| mod_bterm_iter != module_ports.end(); | |
| mod_bterm_iter++) { | |
| for (auto module_port : module_ports) { |
src/dbSta/test/cpp/TestHconn.cpp:130:
- dbModBTerm* module_port = *mod_bterm_iter;
- sprintf(
+ sprintf(
src/dbSta/test/cpp/TestHconn.cpp
Outdated
Comment on lines
151
to
153
| for (dbSet<dbModInst>::iterator mod_inst_iter = module_instances.begin(); | ||
| mod_inst_iter != module_instances.end(); | ||
| mod_inst_iter++) { |
There was a problem hiding this comment.
warning: use range-based for loop instead [modernize-loop-convert]
Suggested change
| for (dbSet<dbModInst>::iterator mod_inst_iter = module_instances.begin(); | |
| mod_inst_iter != module_instances.end(); | |
| mod_inst_iter++) { | |
| for (auto module_inst : module_instances) { |
src/dbSta/test/cpp/TestHconn.cpp:153:
- dbModInst* module_inst = *mod_inst_iter;
- sprintf(tmp_str, "\t\tMod inst %s ", module_inst->getName());
+ sprintf(tmp_str, "\t\tMod inst %s ", module_inst->getName());
src/dbSta/test/cpp/TestHconn.cpp
Outdated
Comment on lines
215
to
217
| for (dbSet<dbModNet>::iterator mod_net_iter = mod_nets.begin(); | ||
| mod_net_iter != mod_nets.end(); | ||
| mod_net_iter++) { |
There was a problem hiding this comment.
warning: use range-based for loop instead [modernize-loop-convert]
Suggested change
| for (dbSet<dbModNet>::iterator mod_net_iter = mod_nets.begin(); | |
| mod_net_iter != mod_nets.end(); | |
| mod_net_iter++) { | |
| for (auto mod_net : mod_nets) { |
src/dbSta/test/cpp/TestHconn.cpp:217:
- dbModNet* mod_net = *mod_net_iter;
- sprintf(
+ sprintf(
Signed-off-by: andyfox-rushc <andy@rushc.com>
Signed-off-by: andyfox-rushc <andy@rushc.com>
Signed-off-by: andyfox-rushc <andy@rushc.com>
Signed-off-by: andyfox-rushc <andy@rushc.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
…m on modnet Signed-off-by: andyfox-rushc <andy@rushc.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a C++ test case which builds a multiple level hierarchical design and exercises the creation of a hierarchical connection. This involved adding a cpp directory to the dbSta/test area. The main contribution of this pull request is a c++ level creation of a hierarchical test case.
Also included is a bug fix to the construction of the hierarchy extraction (getParentHierarchy) code which was causing a seg fault.
Ready for review.