utl:: check if container is empty on utl::shuffle #6446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
reviewed
Dec 30, 2024
Comment on lines
2498
to
2500
| if (!congestionGridsH.empty()) { | ||
| utl::shuffle(congestionGridsH.begin(), congestionGridsH.end(), g); | ||
| } |
There was a problem hiding this comment.
It would be better to make shuffle handle the empty vector correctly so that all users don't need this check.
There was a problem hiding this comment.
if (n == 0) return; should do it
There was a problem hiding this comment.
Thanks! I'm testing it right now and will add it to the PR soon.
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
eder-matheus
changed the title
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Dec 30, 2024
Comment on lines
-2498
to
+2499
| utl::shuffle(congestionGridsV.begin(), congestionGridsV.end(), g); | ||
| utl::shuffle(congestionGridsH.begin(), congestionGridsH.end(), g); | ||
| utl::shuffle(congestionGridsV.begin(), congestionGridsV.end(), g); |
There was a problem hiding this comment.
Is this just a leftover or is there some significance to the order of these lines?
There was a problem hiding this comment.
Just a leftover.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Coverage errors