Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs, tests, fix: fit fibonacci_fast to contributing guidelines #2893

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

docs, tests, fix: fit fibonacci_fast to contributing guidelines #2893

wants to merge 3 commits into from

Conversation

setbit123
Copy link

@setbit123 setbit123 commented Oct 31, 2024 •
edited
Loading

Description of Change

Modify the fibonacci_fast.cpp to fit the project style requirements.
Solve a small part of issue #2456

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@setbit123
Update fibonacci_fast.cpp
93064ae 
Modify the fibonacci_fast.cpp to fit the project style requirements.
@setbit123
Copy link
Author

cc @Panquesito7 @realstealthninja

@realstealthninja realstealthninja changed the title [Fix] Modify the fibonacci_fast.cpp to fit the project style requirements. docs, tests: fit fibonacci_fast to contributing guidelines Nov 20, 2024
realstealthninja
realstealthninja requested changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

math/fibonacci_fast.cpp Outdated Show resolved Hide resolved
math/fibonacci_fast.cpp Show resolved Hide resolved
math/fibonacci_fast.cpp Show resolved Hide resolved
@realstealthninja realstealthninja added the awaiting modification Do not merge until modifications are made label Nov 20, 2024
@setbit123
Copy link
Author

Thank you very much for providing valuable suggestions. I have made an attempt to revise my PR according to your advice.

cc @realstealthninja

@setbit123 setbit123 changed the title docs, tests: fit fibonacci_fast to contributing guidelines docs, tests, fix: fit fibonacci_fast to contributing guidelines Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

@realstealthninja realstealthninja Awaiting requested review from realstealthninja realstealthninja is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
awaiting modification Do not merge until modifications are made
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@setbit123 @realstealthninja