-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Extract galloping methods into static GallopingStrategy class
- Moved galloping logic (GallopLeft, GallopRight, LeftRun, RightRun, FinalOffset) from TimSorter to a new GallopingStrategy static class. - Simplified the code by removing the interface and making all methods static since there's no need for instance-specific behavior. - The refactored GallopingStrategy class now encapsulates galloping functionality, improving modularity and testability. - Updated TimSorter to use GallopingStrategy for gallop operations, enhancing code clarity and separation of concerns.
- Loading branch information
Showing
4 changed files
with
238 additions
and
116 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
120 changes: 120 additions & 0 deletions
120
Algorithms.Tests/Sorters/Utils/GallopingStrategyTests.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| using Algorithms.Sorters.Utils; | ||
| using NUnit.Framework; | ||
| using System.Collections.Generic; | ||
|
|
||
| namespace Algorithms.Tests.Sorters.Utils | ||
| { | ||
| [TestFixture] | ||
| public class GallopingStrategyTests | ||
| { | ||
| private readonly IComparer<int> comparer = Comparer<int>.Default; | ||
|
|
||
| [Test] | ||
| public void GallopLeft_KeyPresent_ReturnsCorrectIndex() | ||
| { | ||
| var array = new[] { 1, 2, 3, 4, 5 }; | ||
| var index = GallopingStrategy<int>.GallopLeft(array, 3, 0, array.Length, comparer); | ||
| Assert.That(index, Is.EqualTo(2)); | ||
| } | ||
|
|
||
| [Test] | ||
| public void GallopLeft_KeyNotPresent_ReturnsCorrectIndex() | ||
| { | ||
| var array = new[] { 1, 2, 4, 5 }; | ||
| var index = GallopingStrategy<int>.GallopLeft(array, 3, 0, array.Length, comparer); | ||
| Assert.That(index, Is.EqualTo(2)); | ||
| } | ||
|
|
||
| [Test] | ||
| public void GallopLeft_KeyLessThanAll_ReturnsZero() | ||
| { | ||
| var array = new[] { 2, 3, 4, 5 }; | ||
| var index = GallopingStrategy<int>.GallopLeft(array, 1, 0, array.Length, comparer); | ||
| Assert.That(index, Is.EqualTo(0)); | ||
| } | ||
|
|
||
| [Test] | ||
| public void GallopLeft_KeyGreaterThanAll_ReturnsLength() | ||
| { | ||
| var array = new[] { 1, 2, 3, 4 }; | ||
| var index = GallopingStrategy<int>.GallopLeft(array, 5, 0, array.Length, comparer); | ||
| Assert.That(index, Is.EqualTo(array.Length)); | ||
| } | ||
|
|
||
| [Test] | ||
| public void GallopRight_KeyPresent_ReturnsCorrectIndex() | ||
| { | ||
| var array = new[] { 1, 2, 3, 4, 5 }; | ||
| var index = GallopingStrategy<int>.GallopRight(array, 3, 0, array.Length, comparer); | ||
| Assert.That(index, Is.EqualTo(3)); | ||
| } | ||
|
|
||
| [Test] | ||
| public void GallopRight_KeyNotPresent_ReturnsCorrectIndex() | ||
| { | ||
| var array = new[] { 1, 2, 4, 5 }; | ||
| var index = GallopingStrategy<int>.GallopRight(array, 3, 0, array.Length, comparer); | ||
| Assert.That(index, Is.EqualTo(2)); | ||
| } | ||
|
|
||
| [Test] | ||
| public void GallopRight_KeyLessThanAll_ReturnsZero() | ||
| { | ||
| var array = new[] { 2, 3, 4, 5 }; | ||
| var index = GallopingStrategy<int>.GallopRight(array, 1, 0, array.Length, comparer); | ||
| Assert.That(index, Is.EqualTo(0)); | ||
| } | ||
|
|
||
| [Test] | ||
| public void GallopRight_KeyGreaterThanAll_ReturnsLength() | ||
| { | ||
| var array = new[] { 1, 2, 3, 4 }; | ||
| var index = GallopingStrategy<int>.GallopRight(array, 5, 0, array.Length, comparer); | ||
| Assert.That(index, Is.EqualTo(array.Length)); | ||
| } | ||
|
|
||
| [Test] | ||
| public void GallopLeft_EmptyArray_ReturnsZero() | ||
| { | ||
| var array = new int[] { }; | ||
| var index = GallopingStrategy<int>.GallopLeft(array, 1, 0, array.Length, comparer); | ||
| Assert.That(index, Is.EqualTo(0)); | ||
| } | ||
|
|
||
| [Test] | ||
| public void GallopRight_EmptyArray_ReturnsZero() | ||
| { | ||
| var array = new int[] { }; | ||
| var index = GallopingStrategy<int>.GallopRight(array, 1, 0, array.Length, comparer); | ||
| Assert.That(index, Is.EqualTo(0)); | ||
| } | ||
|
|
||
| // Test when (shiftable << 1) < 0 is true | ||
| [Test] | ||
| public void TestBoundLeftShift_WhenShiftableCausesNegativeShift_ReturnsShiftedValuePlusOne() | ||
| { | ||
| // Arrange | ||
| int shiftable = int.MaxValue; // This should cause a negative result after left shift | ||
|
|
||
| // Act | ||
| int result = GallopingStrategy<int>.BoundLeftShift(shiftable); | ||
|
|
||
| // Assert | ||
| Assert.That((shiftable << 1) + 1, Is.EqualTo(result)); // True branch | ||
| } | ||
|
|
||
| // Test when (shiftable << 1) < 0 is false | ||
| [Test] | ||
| public void TestBoundLeftShift_WhenShiftableDoesNotCauseNegativeShift_ReturnsMaxValue() | ||
| { | ||
| // Arrange | ||
| int shiftable = 1; // This will not cause a negative result after left shift | ||
|
|
||
| // Act | ||
| int result = GallopingStrategy<int>.BoundLeftShift(shiftable); | ||
|
|
||
| // Assert | ||
| Assert.That(int.MaxValue, Is.EqualTo(result)); // False branch | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.