Skip to content

Add Geohashing Feature with Unit Tests #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 24, 2024
Merged

Conversation

ngtduc693
Copy link
Contributor

@ngtduc693 ngtduc693 commented Oct 24, 2024

This is a new feature for encoding geographic coordinates into Geohash strings using the provided Encode method. The tests have been updated to include various random locations across Vietnam, ensuring the accuracy and reliability of the Geohash encoding process.

image

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md

@ngtduc693 ngtduc693 marked this pull request as ready for review October 24, 2024 02:04
@ngtduc693 ngtduc693 requested a review from siriak as a code owner October 24, 2024 02:04
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.05%. Comparing base (56ca719) to head (a80e22f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
- Coverage   95.06%   95.05%   -0.02%     
==========================================
  Files         256      257       +1     
  Lines       10624    10669      +45     
  Branches     1498     1503       +5     
==========================================
+ Hits        10100    10141      +41     
- Misses        400      403       +3     
- Partials      124      125       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngtduc693
Copy link
Contributor Author

ngtduc693 commented Oct 24, 2024

@siriak Hi there
In this PR, all modified and coverable lines are covered by tests ✅ here

But the whole project's rate is affected because there are other people's code segments that lack unit tests. so what should I do or because other people's code I may not understand

image

image

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak
Copy link
Member

siriak commented Oct 24, 2024

The issue with fluctuating coverage is tracked in #465. If you have time, could you help with that? It's very annoying

@siriak siriak merged commit 013a6b9 into TheAlgorithms:master Oct 24, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants