-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add Geohashing Feature with Unit Tests #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #486 +/- ##
==========================================
- Coverage 95.06% 95.05% -0.02%
==========================================
Files 256 257 +1
Lines 10624 10669 +45
Branches 1498 1503 +5
==========================================
+ Hits 10100 10141 +41
- Misses 400 403 +3
- Partials 124 125 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
The issue with fluctuating coverage is tracked in #465. If you have time, could you help with that? It's very annoying |
This is a new feature for encoding geographic coordinates into
Geohash
strings using the providedEncode
method. The tests have been updated to include various random locations across Vietnam, ensuring the accuracy and reliability of the Geohash encoding process.