Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Tests Coverage - First Batch #229

Closed
wants to merge 1 commit into from

Conversation

samyakkkk
Copy link

@samyakkkk samyakkkk commented Aug 23, 2023

First batch of unit tests added for:

  • data_structures/binary_tree
  • data_structures/Heap/Binary_Heap
    Result: +74 -13

Requesting the team to review :) once approved I'll create subsequent PRs for full test coverage of the codebase.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?
  • Add/Update/Fix test cases.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Dart files are placed inside an existing directory.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@akashgk
Copy link
Member

akashgk commented Aug 23, 2023

hi @samyakkkk Nice work on the Welltestted. But Should we be moving ahead with Ai tested code?
I think since its a repo for learning, wouldnt it be great if we could add some code on our own. Besides there are tons of generated tests, which would make it much harder to learn. I think this is a great product. but would love to see test cases in files with proper formatting, coding practices etc. This PR looks far too big as well.

@akashgk akashgk closed this Aug 23, 2023
@samyakkkk
Copy link
Author

Hi @akashgk thanks for the feedback I can try to create a smaller PR for each file one by one.

Can you please also share what are the specific coding practices we're looking for? Because I think the current code already is following it. :) Look forward to your response. cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants