Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for NodeStack and rework #6009

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lorduke22
Copy link
Contributor

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.33%. Comparing base (90d20b3) to head (3cd1ce4).
Report is 139 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6009      +/-   ##
============================================
+ Coverage     59.71%   69.33%   +9.61%     
- Complexity     3855     4677     +822     
============================================
  Files           561      624      +63     
  Lines         16017    17137    +1120     
  Branches       3073     3311     +238     
============================================
+ Hits           9565    11882    +2317     
+ Misses         6047     4802    -1245     
- Partials        405      453      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lorduke22 lorduke22 requested a review from siriak October 25, 2024 20:29
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) October 26, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants