feat: Add Maven frameworks support #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laingke
commented
Jul 19, 2019
laingke
commented
- Add Maven frameworks support to help it more like a Java project.
- Refact all the testcase by using JUnit Jupiter (in most cases, we can also call it JUnit 5) instead of JUnit 4(ALL refactor is PASSED on my local machine). I consider it necessary for developers to use a newer test API.
- Add a resources directory to help test code reading the specified resource.(It shall be a better implement)
- According to the change above, I update the README by deleting the fourth line from the bottom. Developer can import JUnit automatically.
1. Add JUnit Jupiter dependency; 2. Add maven-resources-plugin to fix path problem in SimplexNoise testcase; 3. Add maven-compiler-plugin to tell the default compiler version;
This was referenced Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.