Skip to content

Wrapping the example matrix with outer array #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

tmkasun
Copy link
Contributor

@tmkasun tmkasun commented Jul 14, 2022

Describe your change:

Without the outer array , given arrays are passed as 4 arguments to the island function

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Without the outer array , given arrays are passed as 4 arguments to the `island` function
appgurueu
appgurueu previously approved these changes Jul 14, 2022
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual tests would be preferable, but this is definitely an improvement.

@appgurueu appgurueu added the fix Fixes a bug label Jul 14, 2022
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we would prefer to have the comments removed and replaced with actual jest tests.

@tmkasun
Copy link
Contributor Author

tmkasun commented Jul 19, 2022

Hi @raklaptudirm & @appgurueu ,

I have added a test file for NumberOfIslands algorithm, Please review and merge.

raklaptudirm
raklaptudirm previously approved these changes Jul 19, 2022
@tmkasun
Copy link
Contributor Author

tmkasun commented Aug 1, 2022

@appgurueu Kind reminder on this

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests have useless names ("Test Case ") currently. Either give them sensible names or move them all into one test block. Please inline to expect(islands(graph)).toBe(n). You might even want to inline graph if you find that it doesn't hinder readability.


Side note: Why does "number of islands" expect strings; could you change it to use numbers instead?

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(the test case names are pretty redundant though)

@tmkasun
Copy link
Contributor Author

tmkasun commented Aug 1, 2022

(the test case names are pretty redundant though)

Yes true, But if I merge them together then it becomes a bit cluttered.

@raklaptudirm Can you please review and merge

@raklaptudirm raklaptudirm merged commit a9e65cd into TheAlgorithms:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants