-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Wrapping the example matrix with outer array #1057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Without the outer array , given arrays are passed as 4 arguments to the `island` function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actual tests would be preferable, but this is definitely an improvement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we would prefer to have the comments removed and replaced with actual jest tests.
Hi @raklaptudirm & @appgurueu , I have added a test file for |
@appgurueu Kind reminder on this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests have useless names ("Test Case ") currently. Either give them sensible names or move them all into one test block. Please inline to expect(islands(graph)).toBe(n)
. You might even want to inline graph
if you find that it doesn't hinder readability.
Side note: Why does "number of islands" expect strings; could you change it to use numbers instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(the test case names are pretty redundant though)
Yes true, But if I merge them together then it becomes a bit cluttered. @raklaptudirm Can you please review and merge |
Describe your change:
Without the outer array , given arrays are passed as 4 arguments to the
island
functionChecklist:
Example:
UserProfile.js
is allowed butuserprofile.js
,Userprofile.js
,user-Profile.js
,userProfile.js
are notFixes: #{$ISSUE_NO}
.