Skip to content

Conversation

@rubiin
Copy link
Contributor

@rubiin rubiin commented Oct 4, 2020

Welcome to JavaScript community

Add a permuation function to get all string permutations

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@rubiin
Copy link
Contributor Author

rubiin commented Oct 5, 2020

@itsvinayak

Copy link
Member

@ruppysuppy ruppysuppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the file name. add a small comment in the beginning about permutations.
Good job btw.

@rubiin
Copy link
Contributor Author

rubiin commented Oct 15, 2020

sure

@rubiin rubiin requested a review from ruppysuppy October 15, 2020 10:54
@ruppysuppy ruppysuppy merged commit 7b2c305 into TheAlgorithms:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants