Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Tree Sort algorithms #513

Closed
wants to merge 1 commit into from
Closed

Added Tree Sort algorithms #513

wants to merge 1 commit into from

Conversation

sonechca
Copy link

@sonechca sonechca commented Oct 25, 2020

Welcome to JavaScript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@sonechca sonechca mentioned this pull request Oct 25, 2020
Copy link
Member

@ruppysuppy ruppysuppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure that the checks pass, its most probably failing due to improper styling. Use standard as mentioned in CONTRIBUTING.md

@itsvinayak itsvinayak added beginner-friendly Easy to implement code style issue Failing style checks good first issue labels Oct 31, 2020
@cclauss
Copy link
Member

cclauss commented Oct 31, 2020

Run standard --fix to automatically fix some problems.

@marsonya
Copy link
Contributor

I think this may be abandoned, but I'll ping one more time, because I think it's great work! @sonechca, could you rebase this and fix the errors?

@marsonya marsonya added the changes required This pull request needs changes label Dec 30, 2020
@marsonya
Copy link
Contributor

marsonya commented Jan 2, 2021

Please comment here to reopen this pull request or create a new PR once you commit the changes requested or make improvements on the code. Thank you for your contributions!

@marsonya marsonya closed this Jan 2, 2021
@cclauss
Copy link
Member

cclauss commented Jan 2, 2021

A contributor who does not have write access to the repo (i.e. they are not a maintainer) does not have the rights to reopen a closed pull request. They would need to open a new PR.

@marsonya
Copy link
Contributor

marsonya commented Jan 4, 2021

A contributor who does not have write access to the repo (i.e. they are not a maintainer) does not have the rights to reopen a closed pull request. They would need to open a new PR.

I stand corrected. Have edited the comment to reflect the correct information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner-friendly Easy to implement changes required This pull request needs changes code style issue Failing style checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants