Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use nim version 2.2.0 #85

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: use nim version 2.2.0 #85

wants to merge 1 commit into from

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Oct 10, 2024

Nim 2.2.0 was released.

Similar to #73. Possible due to #84.

@vil02 vil02 requested a review from dlesnoff October 11, 2024 07:24
dlesnoff
dlesnoff previously approved these changes Oct 11, 2024
View reviewed changes
@ZoomRmc
Copy link
Contributor

ZoomRmc commented Oct 11, 2024 •
edited
Loading

I checked again, as choosenim was brought "home" and setup-nim-action depended on it previously, but it's not anymore, so all should work fine.

If we're trying to track the latest minor version and have manual control over the major, why not just use the nim-version: '2.x'?

@dlesnoff dlesnoff mentioned this pull request Oct 11, 2024
Open
@vil02
Copy link
Member Author

vil02 commented Oct 14, 2024

I think we should still specify the exact version: https://github.com/TheAlgorithms/Nim/actions/runs/11319926449/job/31476691759

dlesnoff
dlesnoff approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@dlesnoff dlesnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, the devel version is also a 2.X version after all. The CI often fails.
You should be able to merge as I am the last pusher.

@vil02
Copy link
Member Author

vil02 commented Oct 18, 2024

You should be able to merge as I am the last pusher.

No I am unable to do that. Even dropping the commits after your review did not help.

@dlesnoff
Copy link
Collaborator

Remove panquesito's review request.

@vil02
Copy link
Member Author

vil02 commented Oct 18, 2024

Remove panquesito's review request.

I cannot. He is a code owner:

Nim/.github/CODEOWNERS

Line 3 in af31828

/.github @Panquesito7

@vil02
Copy link
Member Author

vil02 commented Oct 18, 2024

@dlesnoff: you could merge #73 without @Panquesito7. What has changed?

@dlesnoff
Copy link
Collaborator

dlesnoff commented Oct 20, 2024 •
edited
Loading

New changes require approval from someone other than dlesnoff because they were the last pusher.

Try to close and reopen. You have yet to be added to CODEOWNERS file, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlesnoff dlesnoff dlesnoff approved these changes

@ZoomRmc ZoomRmc ZoomRmc approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vil02 @ZoomRmc @dlesnoff