Skip to content

Change Code to return tuple in dynamic_programming/subset_generation.py #10189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AasheeshLikePanner opened this issue Oct 9, 2023 · 7 comments · May be fixed by #10382
Closed

Change Code to return tuple in dynamic_programming/subset_generation.py #10189

AasheeshLikePanner opened this issue Oct 9, 2023 · 7 comments · May be fixed by #10382
Labels
awaiting triage Awaiting triage from a maintainer

Comments

@AasheeshLikePanner
Copy link
Contributor

AasheeshLikePanner commented Oct 9, 2023 •
edited
Loading

What would you like to share?

The file dynamic_programming/subset_generation.py codes printing the list, which is hard to add doctest in it. And make it cover lower

Changes

Change the code to return tuple so we can add doctests in it and make cover higher

Additional information

No response
@AasheeshLikePanner AasheeshLikePanner added the awaiting triage Awaiting triage from a maintainer label Oct 9, 2023
@AasheeshLikePanner AasheeshLikePanner mentioned this issue Oct 9, 2023
Closed
14 tasks
@AasheeshLikePanner AasheeshLikePanner changed the title Changing Code to return tuple Change Code to return tuple in dynamic_programming/subset_generation.py Oct 9, 2023
@AasheeshLikePanner AasheeshLikePanner mentioned this issue Oct 9, 2023
Merged
14 tasks
@Batty-sk
Copy link

Batty-sk commented Oct 9, 2023

@AasheeshLikePanner can you assign this to me

@thetahayaseen
Copy link

i wannt try?

@TheRealSaiTama
Copy link

i am doing it

@TheRealSaiTama TheRealSaiTama mentioned this issue Oct 11, 2023
Closed
@Paulraj916
Copy link

can you assign this to me

This was referenced Oct 11, 2023
Closed
Closed
@hoarffrost
Copy link

is this issue closed @AasheeshLikePanner @TheRealSaiTama ?

This was referenced Oct 13, 2023
Closed
Closed
Closed
Open
@cclauss
Copy link
Member

cclauss commented Oct 15, 2023

CONTRIBUTING.md says:

Do not create an issue to contribute an algorithm. Please submit a pull request instead.

@cclauss cclauss closed this as completed Oct 15, 2023
@AasheeshLikePanner
Copy link
Contributor Author

@cclauss I created the pull request last week for this. But it still didn't get reviewed So I think creating a issue can help.
Can you please check this #10191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting triage Awaiting triage from a maintainer
Projects
None yet
Milestone
No milestone
7 participants
@cclauss @Paulraj916 @hoarffrost @Batty-sk @thetahayaseen @TheRealSaiTama @AasheeshLikePanner