Skip to content

Additional Features for Binary Tree Implementation #8865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
di-was opened this issue Jul 12, 2023 · 6 comments · Fixed by #10388
Closed

Additional Features for Binary Tree Implementation #8865

di-was opened this issue Jul 12, 2023 · 6 comments · Fixed by #10388
Labels
enhancement This PR modified some existing files

Comments

@di-was
Copy link

di-was commented Jul 12, 2023 •
edited
Loading

Feature description

I would like to modify the basic_binary_tree.py file under datastructures/binary_tree section. I propse adding a new BinaryTree class which will serve as a main interface for creating and manipulating binary trees. Additionally i want all the utilities function of the present file to be the methods of the new class.
@di-was di-was added the enhancement This PR modified some existing files label Jul 12, 2023
@rohan472000
Copy link
Contributor

Propose your thought through PR, so that it can be reviewed and merged if useful.

@paragnimkar

This comment was marked as off-topic.

Sign in to view
@tianyizheng02
Copy link
Contributor

@paragnimkar Read the contributing guidelines:

If you are interested in resolving an open issue, simply make a pull request with your proposed fix. We do not assign issues in this repo so please do not ask for permission to work on an issue.

@dasdebanna dasdebanna mentioned this issue Sep 26, 2023
Closed
14 tasks
@dasdebanna
Copy link

dasdebanna commented Sep 28, 2023 •
edited
Loading

@tianyizheng02
Please see the PR that I have submitted 2 days ago and close this issue #8865

@UjjwalPardeshi

This comment has been minimized.

Sign in to view
@Saswatsusmoy Saswatsusmoy mentioned this issue Oct 13, 2023
Merged
14 tasks
@cclauss
Copy link
Member

cclauss commented Oct 15, 2023

CONTRIBUTING.md says:

Do not create an issue to contribute an algorithm. Please submit a pull request instead.

@cclauss cclauss closed this as completed Oct 15, 2023
@tianyizheng02 tianyizheng02 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
8 participants
@cclauss @tianyizheng02 @dasdebanna @paragnimkar @rohan472000 @di-was @UjjwalPardeshi and others