Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web_programming/convert_number_to_words.py is not web programming #8881

Closed
tianyizheng02 opened this issue Jul 22, 2023 · 5 comments · Fixed by #8998
Closed

web_programming/convert_number_to_words.py is not web programming #8881

tianyizheng02 opened this issue Jul 22, 2023 · 5 comments · Fixed by #8998

Comments

@tianyizheng02
Copy link
Contributor

What would you like to share?

web_programming/convert_number_to_words.py has no web programming whatsoever. It should be moved to a different directory.

Additional information

#8877 shows that this file is among those which broke ruff following the most recent pre-commit update. With how heavily nested the code is (among other questionable coding choices), perhaps it should be rewritten as well.

@tianyizheng02 tianyizheng02 added the awaiting triage Awaiting triage from a maintainer label Jul 22, 2023
@ARUSHI-2004
Copy link

similar result can be achieved using inflect library in python

@tianyizheng02
Copy link
Contributor Author

similar result can be achieved using inflect library in python

@ARUSHI-2004 No, you misunderstand. The entire point of this repo is to implement algorithms from scratch for educational purposes. Using an existing Python library that implements the entire algorithm for us would defeat the whole point.

@cclauss
Copy link
Member

cclauss commented Jul 26, 2023

If web_programming is the wrong category, what is the right category?

@ARUSHI-2004 idea might be quite instructional for 1. testing and 2. benchmarks.

@cclauss cclauss removed the awaiting triage Awaiting triage from a maintainer label Jul 26, 2023
@tianyizheng02
Copy link
Contributor Author

tianyizheng02 commented Jul 26, 2023

If web_programming is the wrong category, what is the right category?

@cclauss conversions, it's in the name: convert_number_to_words.py

@jaxparrow07
Copy link

If web_programming is the wrong category, what is the right category?

@cclauss conversions, it's in the name: convert_number_to_words.py

how ironic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants